Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loading): showLoading align center #13972

Merged
merged 3 commits into from Jan 7, 2021
Merged

fix(loading): showLoading align center #13972

merged 3 commits into from Jan 7, 2021

Conversation

yufeng04
Copy link
Contributor

@yufeng04 yufeng04 commented Jan 7, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  1. show spinner and text
  2. only show spinner
  3. only show text
  • feature: showLoading support fontFamily/fontWeight/fontStyle

Fixed issues

#13892
#13893

Details

Before: What was the problem?

After: How is it fixed in this PR?

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jan 7, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 7, 2021
@pissang pissang merged commit 9dd3e6d into master Jan 7, 2021
@echarts-bot
Copy link

echarts-bot bot commented Jan 7, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix-13892 branch January 7, 2021 12:51
@pissang pissang added this to the 5.0.1 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants