Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected global name usage #13984

Merged
merged 2 commits into from Jan 8, 2021
Merged

Fix unexpected global name usage #13984

merged 2 commits into from Jan 8, 2021

Conversation

pissang
Copy link
Contributor

@pissang pissang commented Jan 8, 2021

Major changes

  1. Avoid unexpected usage of name. Fix data/Source.ts normalizeDimensionsOption 方法直接使用全局 name, 在微信小程序中报错  #13983
  2. Remove node, browser env to avoid unexpected usage of global variables, even like window. Which may lead to compatible issues in specific environements

add no-restricted-globals rule
@echarts-bot
Copy link

echarts-bot bot commented Jan 8, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

100pah
100pah previously approved these changes Jan 8, 2021
@pissang pissang merged commit 6636e4d into master Jan 8, 2021
@echarts-bot
Copy link

echarts-bot bot commented Jan 8, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang added this to the 5.0.1 milestone Jan 8, 2021
@pissang pissang deleted the fix-unexpected-global-name branch January 8, 2021 06:42
@ppbl
Copy link

ppbl commented Jan 8, 2021

这个修复解决了我目前在小程序中使用遇到的问题,想问下大概什么时候可以发布一个版本出来~😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data/Source.ts normalizeDimensionsOption 方法直接使用全局 name, 在微信小程序中报错
3 participants