Fix(tooltip): 'findEventDispatcher' should add 'returnFirstMatch' for tooltip #13992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! The pull request is marked to be |
susiwen8
requested review from
pissang and
100pah
and removed request for
pissang
|
test case: |
|
Thanks for the fix!! https://github.com/apache/incubator-echarts/blob/c4bcc97ee2a0d521872b73f2ebfa9df69fcffac4/src/component/tooltip/TooltipView.ts#L432 seems should add this parameter too. |
@pissang Right, I have missed it. |
pissang
approved these changes
Jan 9, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! |
pissang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
…or tooltip
Brief Information
This pull request is in the type of:
What does this PR do?
Add
returnFirstMatchfortooltipFixed issues
Close #13971
Details
Before: What was the problem?
After: How is it fixed in this PR?
Usage
Are there any API changes?
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information