Fix: improvement and some fix of bar-race (realtimeSort) #13994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…), place the element at the edge of the coordinate system bounding rect with width/height 0. Because if data changed and the element show again, the transition animation of this element will start at this place.
+ When base axis is x, the initial sort should not be different from the subsequent sort.
+ Remove the transition animation of the baseAxis init state to the first sorted state.
+ Fix that throw error when series data does not cover all axis category.
+ Fix some incorrect logic like:
+ BarView sortMap input param
+ OrdinalScale['scale']
+ OrdinalScale['getTicks']
+ Simplify and clarify the params `sortInfo` of action "changeAxisOrder".
```js
// before:
sortInfo: [
// `beforeSortIndex` is not easy to understand and not necessary.
{ ordinalNumber: 2, beforeSortIndex: 4 },
{ ordinalNumber: 5, beforeSortIndex: 5 },
{ ordinalNumber: 3, beforeSortIndex: 0 },
{ ordinalNumber: 4, beforeSortIndex: 2 },
{ ordinalNumber: 0, beforeSortIndex: 3 },
{ ordinalNumber: 1, beforeSortIndex: 1 },
]
// after:
sortInfo: {
ordinalNumbers: [2, 5, 3, 4, 0, 1]
}
```
+ some small refactor: naming, code organization, type. Add comments.
Test cases:
test/bar-race.html
test/bar-race2.html
|
Thanks for your contribution! The pull request is marked to be |
pissang
approved these changes
Jan 9, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Brief Information
This pull request is in the type of:
What does this PR do?
el.ignore: true), place the element at the edge of the coordinate system bounding rect with width/height 0. Because if data changed and the element show again, the transition animation of this element will start at this place.sortInfoof action "changeAxisOrder".