Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(pie): labelLine is not hidden in some case #14017

merged 2 commits into from Jan 26, 2021


Copy link

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Add showLabelLine param for setLabelLineStyle to control labelLine should be drawn or removed.

Fixed issues

Close #13871


Before: What was the problem?

After second setOption. labelLine didn't hide when position is inside.

After: How is it fixed in this PR?

labelLine was hidden after second setOption


Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

The last test case in pie-label.html


Merging options

  • Please squash the commits into a single one when merge.

Other information

Copy link

echarts-bot bot commented Jan 12, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

src/chart/pie/PieView.ts Show resolved Hide resolved
@susiwen8 susiwen8 reopened this Jan 12, 2021
@susiwen8 susiwen8 requested a review from pissang January 12, 2021 08:26
@pissang pissang added this to the 5.1.0 milestone Jan 12, 2021
@pissang pissang modified the milestones: 5.1.0, 5.0.2 Jan 26, 2021
src/chart/pie/PieView.ts Outdated Show resolved Hide resolved
@pissang pissang merged commit 67a8749 into apache:master Jan 26, 2021
Copy link

echarts-bot bot commented Jan 26, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@susiwen8 susiwen8 deleted the labelline branch January 26, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

2 participants