Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(showLoading): #14188 text of loading covered by charts #14191

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

yufeng04
Copy link
Contributor

@yufeng04 yufeng04 commented Feb 2, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix the bug that the text of loading covered by charts

  1. adjust the z-level of loading text
  2. add the test case

Fixed issues

#14188

Details

Before: What was the problem?

After: How is it fixed in this PR?

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Feb 2, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@yufeng04 yufeng04 merged commit 0b33193 into master Feb 2, 2021
@echarts-bot
Copy link

echarts-bot bot commented Feb 2, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

about the zLevel between text and mask for echartsInstance.showLoading()
3 participants