Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): exporting more necessary types for generating declarations in the extensions #14289

Merged
merged 1 commit into from Feb 19, 2021

Conversation

pissang
Copy link
Contributor

@pissang pissang commented Feb 19, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

For some unknown reason, vue-echarts#next will have Default export of the module has or is using private name error when generating declarations. It only happens when reexporting wrapped ECharts#getDataURL, ECharts#getConnectedDataURL, ECharts#dispatchAction methods to the vue component.

So in this PR, we export these necessary private types to avoid this issue:

  • echarts.Color
  • echarts.Payload
  • echarts.LinearGradientObject
  • echarts.RadialGradientObject
  • echarts.LinearGradientObject
  • echarts.SetOptionOpts

@echarts-bot
Copy link

echarts-bot bot commented Feb 19, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang added this to the 5.1.0 milestone Feb 19, 2021
@pissang pissang changed the title fix(type): exporting more necessary types fix(type): exporting more necessary types for generating declarations in the extensions Feb 19, 2021
@pissang pissang merged commit 6a7ac85 into master Feb 19, 2021
@echarts-bot
Copy link

echarts-bot bot commented Feb 19, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the export-types branch February 19, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants