fix(markLine): fix a bug that markLine symbolOffset doesn't work and some other issues.
#14375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolves #9325 - Resolves #14106 - Resolves #4771 2) feat: `markLine.symbolRotate` can be an array to specify symbol rotation at the two endpoints. - Related #12736, #12392 3) feat: add `markLine.symbolKeepAspect` and fix `symbolKeepAspect` doesn't work bug. 4) feat: `symbolOffset` can be a callback function, close #12495.
|
Thanks for your contribution! The pull request is marked to be Document changes are required in this PR. Please also make a PR to apache/incubator-echarts-doc for document changes. When the doc PR is merged, the maintainers will remove the |
echarts-bot
bot
added
PR: author is committer
PR: awaiting doc
pissang
approved these changes
Mar 30, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Ovilia
added a commit
that referenced
this pull request
Apr 6, 2021
This may be a bug raised from #14375
5 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
1) fix: markLine
symbolOffsetdoesn't work bug2) feat:
markLine.symbolRotatecan be an array to specify symbol rotation at the two endpoints.symbolRotateformarkLinedoes not work. close #12388. #12392, Symbol rotate for markLine dose not work on line chart #123883) feat: add
markLine.symbolKeepAspectand fixsymbolKeepAspectdoesn't work bug.4) feat:
symbolOffsetcan be a callback functionFixed issues
symbolRotateformarkLinedoes not work. close #12388. #12392 (comment)Details
Before: What was the problem?
After: How is it fixed in this PR?
Usage
Are there any API changes?
Related test cases or examples to use the new APIs
Please refer to
test/markLine-symbolRotate.htmlandtest/symbol3.html.Others
Merging options
Other information