Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markLine): fix a bug that markLine symbolOffset doesn't work and some other issues. #14375

merged 6 commits into from Mar 30, 2021


Copy link

@plainheart plainheart commented Mar 1, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

1) fix: markLine symbolOffset doesn't work bug

2) feat: markLine.symbolRotate can be an array to specify symbol rotation at the two endpoints.

3) feat: add markLine.symbolKeepAspect and fix symbolKeepAspect doesn't work bug.

4) feat: symbolOffset can be a callback function

Fixed issues


Before: What was the problem?

After: How is it fixed in this PR?


Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

Please refer to test/markLine-symbolRotate.html and test/symbol3.html.


Merging options

  • Please squash the commits into a single one when merge.

Other information

- Resolves #9325
- Resolves #14106
- Resolves #4771
2) feat: `markLine.symbolRotate` can be an array to specify symbol rotation at the two endpoints.
- Related #12736, #12392
3) feat: add `markLine.symbolKeepAspect` and fix `symbolKeepAspect` doesn't work bug.
4) feat: `symbolOffset` can be a callback function, close #12495.
Copy link

echarts-bot bot commented Mar 1, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Document changes are required in this PR. Please also make a PR to apache/incubator-echarts-doc for document changes. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@pissang pissang added this to the 5.1.0 milestone Mar 2, 2021
@plainheart plainheart merged commit a39c4a1 into master Mar 30, 2021
Copy link

echarts-bot bot commented Mar 30, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
PR: author is committer PR: awaiting doc Document changes is required for this PR. size/L
None yet
2 participants