Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolbox): the show option of customized toolbox button does not work. #14408

merged 1 commit into from May 12, 2021


Copy link

@plainheart plainheart commented Mar 5, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

The visibility of the customized toolbox button cannot be controlled by the show option.

Fixes #14405
Fixes #14618

Fixed issues


Before: What was the problem?

The customized toolbox button is still visible when show is set to be false.


After: How is it fixed in this PR?



Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

Please refer to test/toolbox-custom.html.


Merging options

  • Please squash the commits into a single one when merge.

Other information

Copy link

echarts-bot bot commented Mar 5, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang merged commit 0ac6f31 into master May 12, 2021
@pissang pissang deleted the fix-toolbox-custom branch May 12, 2021 09:23
Copy link

echarts-bot bot commented May 12, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants