Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): fix time axis formatter #14470 #14471

Merged
merged 1 commit into from Mar 15, 2021
Merged

fix(tooltip): fix time axis formatter #14470 #14471

merged 1 commit into from Mar 15, 2021

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Mar 15, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix default time axis formatter so that the time template can be used in tooltip.

Fixed issues

Details

Before: What was the problem?

Wrong tooltip content
image

After: How is it fixed in this PR?

Correct tooltip content
image

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Mar 15, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@Ovilia Ovilia merged commit 0456847 into master Mar 15, 2021
@Ovilia Ovilia deleted the fix-14470 branch March 15, 2021 06:35
@echarts-bot
Copy link

echarts-bot bot commented Mar 15, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang added this to the 5.1.0 milestone Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip is wrong in custom-gantt-flight example
3 participants