Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(option): optimize error log when components or series are missing #14568

Merged
merged 11 commits into from Apr 1, 2021

Conversation

pissang
Copy link
Contributor

@pissang pissang commented Mar 31, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  1. Enhances the error log when built-in components or series are missing.
  2. Fixes some issues in unit tests.
  3. Only initialize markPoint / markLine / markArea component when they are used in series

Limitations:

  1. Missing of components in extension like echarts-gl still can't be checked.

Fixed issues

#14325

Details

Before: What was the problem?

There is no log when components are missing. It may cause other more obscure errors which make developers hard to find out what the problem is.

After: How is it fixed in this PR?

Add more detailed components or series missing log.

image

image

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Mar 31, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang merged commit 09ddced into master Apr 1, 2021
@echarts-bot
Copy link

echarts-bot bot commented Apr 1, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the enhance-missing-components-log branch April 1, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants