Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gauge): Add data index and series index for indexing the data #14688

merged 3 commits into from
Jul 15, 2021


Copy link

@yufeng04 yufeng04 commented Apr 16, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Clicking on the progress in the gauge chart you can get an event

Fixed issues



Before: What was the problem?

After: How is it fixed in this PR?

Add data index and series index for indexing the data by element in gauge
Useful in tooltip


Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs



Merging options

  • Please squash the commits into a single one when merge.

Other information

Copy link

echarts-bot bot commented Apr 16, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

const setItemDataAndSeriesIndex = function (this: Element, child: Element): void {
const childECData = getECData(child);
const thisECData = getECData(this);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this context is wrong here. It's not the root element in setCommenECData

Use anonymous function in setCommonECData is fine. JS engine will handle it well and won't have a performance issue. Use a separate function with a specified this context will be easy to have the above issue.

@pissang pissang added this to the 5.2.0 milestone Apr 20, 2021
@pissang pissang merged commit d61ef0c into master Jul 15, 2021
Copy link

echarts-bot bot commented Jul 15, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants