Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markLine): symbolOffset incorrectly marked as mandatory #14693



Copy link

@villebro villebro commented Apr 17, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

When upgrading the ECharts dependency in Superset from 5.0.2 to 5.1.0, I noticed that symbolOffset in MarkLine1DDataItemOption is marked as mandatory, while it's optional in MarkLine2DDataItemOption. I believe this parameter can be made optional.

Fixed issues

  • Incorrect type checking

Merging options

  • Please squash the commits into a single one when merge.

Other information

Copy link

echarts-bot bot commented Apr 17, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Copy link

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This is my fault in #14375.

Copy link
Member Author

Thanks for the review @plainheart - is it ok to merge now?

Copy link

is it ok to merge now?

I think this should be okay.

@plainheart plainheart merged commit af367b8 into apache:master Apr 17, 2021
Copy link

echarts-bot bot commented Apr 17, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Copy link
Member Author

Btw sorry for not catching this sooner! I meant to test the 5.1.0 release candidate, but I ran out of time before the vote was closed. But anyway, this is mostly a cosmetic issue, so probably not something that requires a new release.

@villebro villebro deleted the villebro/fix-markline/symbolOffset branch April 17, 2021 07:59
@plainheart plainheart linked an issue Apr 19, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

markLine requires symbolOffset (BC break)
2 participants