Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map): ensure children have been added to group before calling resetEventTriggerForRegion. #14704

merged 1 commit into from Apr 20, 2021


Copy link

@plainheart plainheart commented Apr 19, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix #14699
Fix #14701
Fix #14708

Fixed issues


Before: What was the problem?

The tooltip can't show because of missing seriesIndex in the inner store of the element of zrender.
The seriesIndex will be set by, eventTrigger) in resetEventTriggerForRegion.
But regionGroup has no children yet when calling resetEventTriggerForRegion for the inappropriate invoking order, which causes the el.traverse(setItemDataAndSeriesIndex, el); won't be invoked.


After: How is it fixed in this PR?

Adjust the invoking order.


Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

Please refer to test/map-default.html


Merging options

  • Please squash the commits into a single one when merge.

Other information

@pissang pissang merged commit d80bdfb into master Apr 20, 2021
Copy link

echarts-bot bot commented Apr 20, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Copy link

fazulk commented Apr 21, 2021

When will this be made available?

@pissang pissang mentioned this pull request Apr 22, 2021
Copy link

pissang commented Apr 23, 2021

@fazulk It will be included in 5.1.1. Which will be released in the early next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment