Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legend): remove unexpected syntax to ensure better compatibility. #14810

merged 1 commit into from May 12, 2021


Copy link

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Remove unexpected syntax String.startsWith from LegendView to ensure better compatibility.

This syntax is not supported in IE, so use lastIndexOf(search, 0) === 0 instead.

Fixed issues



Before: What was the problem?

The chart cannot be rendered in IE and threw a syntax error about startsWith.

After: How is it fixed in this PR?

Use lastIndexOf(search, 0) === 0 instead.


  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs



Merging options

  • Please squash the commits into a single one when merge.

Other information

…se `lastIndexOf(search, 0) === 0` instead.
Copy link

echarts-bot bot commented Apr 27, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang merged commit d9e1fcf into master May 12, 2021
@pissang pissang deleted the fix-grammar branch May 12, 2021 09:18
Copy link

echarts-bot bot commented May 12, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants