Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(treemap): error when running setOption twice with diff data #14930

merged 2 commits into from May 17, 2021


Copy link

@Map1en Map1en commented May 13, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed the bug of running setOption twice in treemap chart with different data

Fixed issues

close #14857


Before: What was the problem?

treemap error when running setOption twice with diff data

After: How is it fixed in this PR?

use ternary operator
add one visual test
rename one visual test


  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs



Merging options

  • Please squash the commits into a single one when merge.

Other information

Copy link

echarts-bot bot commented May 13, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

src/chart/treemap/TreemapSeries.ts Outdated Show resolved Hide resolved
@pissang pissang added this to the 5.1.2 milestone May 13, 2021
@pissang pissang merged commit 788872a into apache:master May 17, 2021
Copy link

echarts-bot bot commented May 17, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Map1en Map1en deleted the fix-treemap-err-when-setOption-twice branch May 17, 2021 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Treemap chart error when setOption twice with dfifferent data
2 participants