Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(option): check the missing component before merge theme #14966

Merged
merged 2 commits into from May 17, 2021

Conversation

pissang
Copy link
Contributor

@pissang pissang commented May 17, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Previously we do component missing check after merged theme. It may cause false alarm. In this PR we brought the check before merging theme.

Fixed issues

#14844

@echarts-bot
Copy link

echarts-bot bot commented May 17, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pull-request-size pull-request-size bot added size/S and removed size/M labels May 17, 2021
@pissang pissang requested a review from 100pah May 17, 2021 08:10
@pissang pissang merged commit 35a15f8 into master May 17, 2021
@echarts-bot
Copy link

echarts-bot bot commented May 17, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix-component-missing-error branch May 17, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants