Skip to content

fix(tooltip): position callback return type. close #15030 - #15031

Merged
pissang merged 1 commit into
apache:masterfrom
congjiujiu:fix/tooltip-position-callback-type
May 26, 2021
Merged

fix(tooltip): position callback return type. close #15030#15031
pissang merged 1 commit into
apache:masterfrom
congjiujiu:fix/tooltip-position-callback-type

Conversation

@congjiujiu

@congjiujiu congjiujiu commented May 25, 2021

Copy link
Copy Markdown

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

fix tooltip position callback return types

Fixed issues

Details

Before: What was the problem?

image

After: How is it fixed in this PR?

change the return type to Array<number | string>

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot

echarts-bot Bot commented May 25, 2021

Copy link
Copy Markdown

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang

pissang commented May 25, 2021

Copy link
Copy Markdown
Contributor

@congjiujiu TypeScript check fails.

image

@congjiujiu
congjiujiu force-pushed the fix/tooltip-position-callback-type branch from ea25e07 to 9c28349 Compare May 25, 2021 13:17
@congjiujiu

Copy link
Copy Markdown
Author

@pissang fixed

@pissang
pissang merged commit c695011 into apache:master May 26, 2021
@echarts-bot

echarts-bot Bot commented May 26, 2021

Copy link
Copy Markdown

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@congjiujiu
congjiujiu deleted the fix/tooltip-position-callback-type branch May 26, 2021 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants