Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(endLabel): endLabel should be displayed if show is true #15072

merged 3 commits into from Jun 3, 2021


Copy link

@Ovilia Ovilia commented Jun 2, 2021

fix(endLabel): endLabel should be displayed if show is true in other states #14441

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

If is false, endLabel will not show on emphasis even when there is true.

Fixed issues


Before: What was the problem?

End label not show on emphasis

After: How is it fixed in this PR?

End label show on emphasis


  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs



Merging options

  • Please squash the commits into a single one when merge.

Other information

Copy link

echarts-bot bot commented Jun 2, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang added this to the 5.2.0 milestone Jun 3, 2021
src/chart/line/LineView.ts Outdated Show resolved Hide resolved
@Ovilia Ovilia merged commit 3dbb082 into master Jun 3, 2021
@Ovilia Ovilia deleted the fix-endLabel branch June 3, 2021 10:20
Copy link

echarts-bot bot commented Jun 3, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

plainheart added a commit that referenced this pull request Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants