Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lines): fix lines can't be cleared by chart.clear() #15088

Merged
merged 3 commits into from
Jun 17, 2021
Merged

Conversation

plainheart
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix lines can't be cleared by chart.clear().

Fixed issues

Details

Before: What was the problem?

After: How is it fixed in this PR?

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to test/lines-bus.html and click the button Clear('chart.clear')

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

BTW, removed unused import DISPLAY_STATES in LineView.ts to resolve the maxlen lint error, brought by #15072.

@echarts-bot
Copy link

echarts-bot bot commented Jun 5, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang merged commit cd3b7e6 into master Jun 17, 2021
@pissang pissang deleted the fix-lines-clear branch June 17, 2021 02:50
@echarts-bot
Copy link

echarts-bot bot commented Jun 17, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment