Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:emphasis color inherit support #15172

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Conversation

Foreverwzh
Copy link

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

allow emphasis.itemStyle.color = 'inherit'

Fixed issues

Details

Before: What was the problem?

The emphasis color has to be set to same value as normal color when we expect the emphasis color not change. But if we use global setting colors or default colors, this would be a big problem.

After: How is it fixed in this PR?

set emphasis.itemStyle.color = 'inherit'

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

test/emphasis-inherit.html

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jun 17, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@pissang pissang changed the title feat(pie):emphasis color inherit support feat:emphasis color inherit support Jun 22, 2021
@pissang pissang merged commit 08fa2e7 into apache:master Jun 22, 2021
@echarts-bot
Copy link

echarts-bot bot commented Jun 22, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants