fix(pie/sunburst): fix borderRadius can't be reset in pie series and sunburst series when setting it to null or undefined
#15243
Conversation
…d sunburst series through `chart.setOption({ series: { itemStyle: { borderRadius: null } } })`, resolves #15242.
|
Thanks for your contribution! The pull request is marked to be |
| ) { | ||
| let cornerRadius = model.get('borderRadius'); | ||
| if (cornerRadius == null) { | ||
| return null; | ||
| return zeroIfNull ? {innerCornerRadius: 0, cornerRadius: 0} : null; |
There was a problem hiding this comment.
I think it's fine to return { innerCornerRadius: 0, cornerRadius: 0 } directly. It will make this function simpler.
There was a problem hiding this comment.
But that will make the other states incorrect. For example, we specify the borderRadius as 5 in the normal state, what expected should be also 5 in the emphasis state, but if we use directly { innerCornerRadius: 0, cornerRadius: 0 }, it will break this (reset to be 0). Thus using null is reasonable.
There was a problem hiding this comment.
You are right, I totally forgot that.
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
Fix the bug that
borderRadiuscan't be reset in pie series and sunburst series when setting it tonull.Fixed issues
Details
Before: What was the problem?
borderRadiusdoesn't be removed when setting it tonullorundefined.After: How is it fixed in this PR?
Set
borderRadiusto0if it'snullorundefined.Misc
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information