Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bar): set label to be inside when position is middle #15309

Merged
merged 2 commits into from Jul 8, 2021
Merged

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Jul 8, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

#15182 enables user to set the polar bar labels to be 'middle'. But color may not have enough contrast to the background. In this PR, we set the text to be inside when position is 'middle' for polar bars.

Before

image

After

image

@echarts-bot
Copy link

echarts-bot bot commented Jul 8, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

src/chart/bar/BarView.ts Outdated Show resolved Hide resolved
@Ovilia Ovilia merged commit 1e36890 into master Jul 8, 2021
@echarts-bot
Copy link

echarts-bot bot commented Jul 8, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia deleted the fix-bar-middle branch July 8, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants