Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): tooltip should show DOM content instead of the string [object HTMLSpanElement] #15313

Merged
merged 3 commits into from Jul 15, 2021

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Jul 8, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  1. fix(tooltip): tooltip should show DOM content instead of the string [object HTMLSpanElement], resolves Tooltip formatter doesn't renders HTMLElement if tooltip position is 'top', 'left', 'bottom', 'right', 'inside'. #15307.

  2. fix(tooltip): should clear the DOM content if user-specified content is null, resolves report a problem, that is the tooltip of type map. #14832. Related previous commit: 3ddb125

  3. feat(tooltip): formatter can be HTMLElement. (only string/HTMLElement array previously)

  4. chore(tooltip): don't show arrow when empty.

Fixed issues

Details

Before: What was the problem?

  1. Tooltip shows [object HTMLSpanElement] instead of expected DOM content.

  2. Tooltip doesn't hide when content is null.

After: How is it fixed in this PR?

  1. Tooltip shows DOM content instead of the string [object HTMLSpanElement]

  2. Hide tooltip when content is null

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Tooltip formatted now accepts single HTMLElement.

Related test cases or examples to use the new APIs

Please refer to test/tooltip-domnode.html and #14832.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

…g [object HTMLSpanElement], resolves #15307.

2) feat(tooltip): formatter can be HTMLElement. (only string/HTMLElement array previously)

3) chore(tooltip): don't show arrow when empty.
@echarts-bot
Copy link

echarts-bot bot commented Jul 8, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@echarts-bot echarts-bot bot added PR: author is committer PR: awaiting doc Document changes is required for this PR. PR: awaiting review labels Jul 8, 2021
@pissang pissang added this to the 5.2 milestone Jul 8, 2021
@pissang pissang merged commit 6e32f07 into master Jul 15, 2021
@pissang pissang deleted the fix-tooltip-dom branch July 15, 2021 06:58
@echarts-bot
Copy link

echarts-bot bot commented Jul 15, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants