Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(effectScatter): make ripple effect count configurable #15335

Merged
merged 3 commits into from Jul 13, 2021

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Jul 13, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Allow configuring the number of ripple in effectScatter series.

Fixed issues

Details

Before: What was the problem?

The count of ripple effect is hard-coded 3.

After: How is it fixed in this PR?

Make ripple effect count configurable. 3 by default.

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Add a new option number into rippleEffect option.

Related test cases or examples to use the new APIs

Please refer to effectScatter.html

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@plainheart plainheart added PR: awaiting doc Document changes is required for this PR. PR: awaiting review labels Jul 13, 2021
@pissang pissang added this to the 5.2 milestone Jul 13, 2021
@pissang pissang merged commit dc9af24 into master Jul 13, 2021
@echarts-bot
Copy link

echarts-bot bot commented Jul 13, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the feat-ripple-effect-count branch July 13, 2021 03:52
plainheart added a commit to apache/echarts-doc that referenced this pull request Jul 15, 2021
pissang added a commit to apache/echarts-doc that referenced this pull request Jul 15, 2021
feat(effectScatter): add a new option `rippleEffect.number` introduced by apache/echarts#15335.
@plainheart plainheart removed the PR: awaiting doc Document changes is required for this PR. label Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants