Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sankey): gradient should follow orient #15363

Merged
merged 1 commit into from Jul 16, 2021

Conversation

susiwen8
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Sankey line's gradient color should folllow orient.

Fixed issues

Close #15358

Details

Before: What was the problem?

Screen Shot 2021-07-15 at 11 34 53 PM

After: How is it fixed in this PR?

Screen Shot 2021-07-15 at 11 34 40 PM

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

sankey.html

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jul 15, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang merged commit 8f0d8d7 into apache:master Jul 16, 2021
@pissang pissang added this to the 5.2 milestone Jul 16, 2021
@echarts-bot
Copy link

echarts-bot bot commented Jul 16, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@susiwen8 susiwen8 deleted the sankey-linecolor-vertical branch July 16, 2021 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants