Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(candlestick): fix style lost after update #15368

Merged
merged 2 commits into from Jul 16, 2021
Merged

Conversation

pissang
Copy link
Contributor

@pissang pissang commented Jul 16, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Previously candlestick will pick the value item from the data object when clone. Which will lose itemStyle and other configurations. Now it changes to clone the whole object

Fixed issues

#15017

@echarts-bot
Copy link

echarts-bot bot commented Jul 16, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang added this to the 5.2 milestone Jul 16, 2021
@pissang pissang requested review from Ovilia and 100pah July 16, 2021 03:19
Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pissang pissang merged commit c6edd70 into master Jul 16, 2021
@echarts-bot
Copy link

echarts-bot bot commented Jul 16, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix-candlestick-update branch July 16, 2021 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants