Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13195 - Update way of parsing date #15410

Merged
merged 2 commits into from Jul 28, 2021
Merged

Conversation

quillblue
Copy link
Contributor

@quillblue quillblue commented Jul 25, 2021

Important Note

This is a re-commit for original PR #13227 . I didn't modify the original one because due to some reason I can not find my original branch.

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

The PR updated way of parsing 7th part of date string from simply treat it as milliseconds to pick first 3 digits as milliseconds to avoid unexpected result when backend API return date string with precision of microseconds.

Fixed issues

#13195

Details

Before: What was the problem?

Though 3 digits milliseconds is widely used in most situations, some date formatter will return date string 6 digit microseconds (yyyy-MM-ddTHH:mm:ss.micros) . ECharts will treat micro seconds as milliseconds when parsing DateTime string and cause unexpected result.

After: How is it fixed in this PR?

Keep conistent with default constructor of JavaScript Date - only pick first 3 digits when the length of input part between dot and zulu time marker is longer than 3 digits.

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jul 25, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

src/util/number.ts Outdated Show resolved Hide resolved
@pissang pissang changed the title (Rework for #13227) Apply original fix for #13195 based on latest master Fix #13195 - Update way of parsing date Jul 28, 2021
@pissang pissang added this to the 5.2 milestone Jul 28, 2021
@pissang pissang merged commit 1bbeff5 into apache:master Jul 28, 2021
@echarts-bot
Copy link

echarts-bot bot commented Jul 28, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants