Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce memory when chart instance is still hold after dispose #15417

Merged
merged 1 commit into from Jul 28, 2021

Conversation

pissang
Copy link
Contributor

@pissang pissang commented Jul 27, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

This PR does a small change on the dispose method. It will reduce the memory cost when the project still holds the ECharts instance after it's disposed.

@echarts-bot
Copy link

echarts-bot bot commented Jul 27, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang merged commit 2364f55 into master Jul 28, 2021
@echarts-bot
Copy link

echarts-bot bot commented Jul 28, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the optimize-dispose branch July 28, 2021 01:47
@pissang pissang added this to the 5.2 milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants