Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 'convertFromEC4CompatibleStyle' to convert font related attributes #15454

Merged
merged 1 commit into from Aug 2, 2021
Merged

support 'convertFromEC4CompatibleStyle' to convert font related attributes #15454

merged 1 commit into from Aug 2, 2021

Conversation

AmosChenYQ
Copy link
Contributor

…butes

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Try to support convert font related attributes.

Fixed issues

#14727
#15105

Details

Before: What was the problem?

Can not change font size or weight.

image

After: How is it fixed in this PR?

Can support to change it.

image

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jul 31, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@AmosChenYQ
Copy link
Contributor Author

https://github.com/apache/echarts/blob/master/src/util/styleCompat.ts#L92
not quite sure why not support these attributes then, maybe because of this reason?

@pissang
Copy link
Contributor

pissang commented Aug 2, 2021

@AmosChenYQ Thanks for the fix. I think it's just forgotten.

@pissang pissang merged commit 997f839 into apache:master Aug 2, 2021
@echarts-bot
Copy link

echarts-bot bot commented Aug 2, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang added this to the 5.2 milestone Aug 2, 2021
@pissang pissang changed the title support 'convertFromEC4CompatibleStyle' to convert font related attri… support 'convertFromEC4CompatibleStyle' to convert font related attributes Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants