Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: time axis overlapped labels #15583

Merged
merged 5 commits into from Sep 2, 2021
Merged

Fix: time axis overlapped labels #15583

merged 5 commits into from Sep 2, 2021

Conversation

svedova
Copy link
Contributor

@svedova svedova commented Aug 23, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

This PR fixes the overlapping labels in the Time Axis.

Fixed issues

Details

Before After
Screenshot 2021-08-23 at 13 22 15 Screenshot 2021-08-23 at 13 21 54

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Aug 23, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@svedova
Copy link
Contributor Author

svedova commented Aug 23, 2021

@pissang can you please review this MR and tell me if it's in the right direction?

@pissang pissang added this to the 5.2 milestone Aug 24, 2021
@pissang
Copy link
Contributor

pissang commented Aug 24, 2021

@svedova Thanks! This change looks good to me and the result looks great! Perhaps we can limit this hiding overlap strategy to the time axis currently.

@svedova
Copy link
Contributor Author

svedova commented Aug 24, 2021

@pissang great idea! I've applied the suggested changes and here's the screenshot that shows the chart is still working as expected:

image

I'm going to ask for another round of review 🙏

src/component/axis/AxisBuilder.ts Outdated Show resolved Hide resolved
src/component/axis/AxisBuilder.ts Outdated Show resolved Hide resolved
src/component/axis/AxisBuilder.ts Outdated Show resolved Hide resolved
@svedova
Copy link
Contributor Author

svedova commented Aug 25, 2021

@pissang Thanks a lot for the second round review! Your help is hugely appreciated. I've submitted another commit with the suggested changes, so now back to you 🏓

src/component/axis/AxisBuilder.ts Outdated Show resolved Hide resolved
src/component/axis/AxisBuilder.ts Outdated Show resolved Hide resolved
@svedova
Copy link
Contributor Author

svedova commented Aug 26, 2021

@pissang applied the changes, thanks for your help 🏓

@pissang pissang removed this from the 5.2 milestone Aug 26, 2021
@pissang pissang added this to the 5.2.1 milestone Aug 26, 2021
@svedova svedova requested a review from pissang August 26, 2021 09:51
@pissang pissang merged commit f46b404 into apache:master Sep 2, 2021
@echarts-bot
Copy link

echarts-bot bot commented Sep 2, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants