Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(polar): wrong sector clockwise when previous data is 0 #15517 #15589

Merged
merged 6 commits into from Sep 13, 2021

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Aug 24, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix sector clockwise when previous data is 0.

Fixed issues

Details

Before: What was the problem?

If old data is 0, the sector will be anti-clockwise.

After: How is it fixed in this PR?

If old data is 0, the sector will be clockwise.

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

  • test/bar-polar-basic.html

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Aug 24, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

src/chart/bar/BarView.ts Outdated Show resolved Hide resolved
@Ovilia Ovilia marked this pull request as ready for review September 8, 2021 05:56
@Ovilia Ovilia added this to the 5.2.1 milestone Sep 10, 2021
@Ovilia Ovilia merged commit fde66ec into master Sep 13, 2021
@echarts-bot
Copy link

echarts-bot bot commented Sep 13, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants