Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(line): not stop existing expand animation when update. #15599

merged 1 commit into from Sep 2, 2021


Copy link

@Ovilia Ovilia commented Aug 25, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Line clipping animation was skipped if calling setOption when the first clipping animation is not done.

Fixed issues



Before: What was the problem?

option = {
    xAxis: {
        type: 'category',
        boundaryGap: false,
        data: ['Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat', 'Sun']
    yAxis: {
        type: 'value'
    series: [{
        data: [820, 932, 901, 934, 1290, 1330, 1320],
        type: 'line',
        areaStyle: {}
    animationDuration: 5000,
    animationDurationUpdate: 5000

setTimeout(function() {
}, 1000);

After: How is it fixed in this PR?

Clipping animation should be continued.


  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs



Merging options

  • Please squash the commits into a single one when merge.

Other information

Copy link

echarts-bot bot commented Aug 25, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang changed the title fix(line): fix line chart animation #15581 fix(line): not stop existing expand animation when update. Sep 2, 2021
@pissang pissang merged commit ce461a6 into master Sep 2, 2021
Copy link

echarts-bot bot commented Sep 2, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix-line-animation branch September 2, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

fix(line): line chart animation is not replayed when calling setOption twice
2 participants