Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [type]: improve option types #15696

Merged
merged 9 commits into from Sep 9, 2021
Merged

[fix] [type]: improve option types #15696

merged 9 commits into from Sep 9, 2021

Conversation

pissang
Copy link
Contributor

@pissang pissang commented Sep 9, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

This PR aimed to improve option types found during the work of rewriting example code with TypeScript. It includes:

  1. Improve return type in renderItem of custom series.
  2. Export CustomSeriesRenderItem, CustomSeriesRenderItemParams, CustomSeriesRenderItemAPI, CustomSeriesRenderItemReturn
  3. More precise axis type inference based on axis.type.
  4. Fix callback type in itemStyle.color Typescript error on using callback for itemStyle.color #14279
  5. Fix emphasis, blur, select is any in some series.

@echarts-bot
Copy link

echarts-bot bot commented Sep 9, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang changed the title [fix] [type]: improve optiontypes [fix] [type]: improve option types Sep 9, 2021
@pissang pissang added this to the 5.2.1 milestone Sep 9, 2021
@pissang pissang merged commit b730055 into master Sep 9, 2021
@echarts-bot
Copy link

echarts-bot bot commented Sep 9, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the improve-types branch September 9, 2021 06:05
@gehringf
Copy link

Been struggling with typing renderItem last week. Thanks for your great work! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants