Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): format boolean in value #15809 #15869

merged 2 commits into from Oct 14, 2021

fix(tooltip): format boolean in value #15809 #15869

merged 2 commits into from Oct 14, 2021


Copy link

@Ovilia Ovilia commented Oct 12, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix formating boolean values in tooltips.

Fixed issues



Before: What was the problem?

Boolean values in data are formatted to be '-' for both true and false values in the tooltip.

After: How is it fixed in this PR?

Boolean values in data are formatted to be 'true' and 'false' in the tooltip.


  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs



Merging options

  • Please squash the commits into a single one when merge.

Other information

Please let me know if typeof value === 'boolean' should be wrapped into a zrender util method.

Copy link

echarts-bot bot commented Oct 12, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@Ovilia Ovilia added this to the 5.2.2 milestone Oct 12, 2021
@Ovilia Ovilia linked an issue Oct 12, 2021 that may be closed by this pull request
src/util/format.ts Outdated Show resolved Hide resolved
@Ovilia Ovilia merged commit cd782ab into master Oct 14, 2021
@Ovilia Ovilia deleted the fix-15809 branch October 14, 2021 02:43
Copy link

echarts-bot bot commented Oct 14, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Tooltip not showing boolean values
3 participants