fix(performance): optimize progressive rendering performance #15870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also for series with trail effect
|
Thanks for your contribution! The pull request is marked to be |
100pah
approved these changes
Oct 15, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Before this change for each frame during progressive rendering, we will traverse all elements in the storage to update z, blend, states, etc. Which brings lots of unnecessary extra cost because we only have to update the new rendered elements.
So this PR we add
eachRenderedmethod to traverse the new rendered elements inview/Chart.ts. And for the series that support progressive rendering will be responsible to manage which elements are rendered in this frame. When updating z, blend, states, we can simply useeachRenderedinstead of previouslyview.group.traverse.Besides this major change. We also drop the use of
IncrementalDisplayable. It seems to be an overdesign. We only use it inLargeSymbolDrawandLargeLineDraw. For these two cases, we can merge the points to reduce the number of elements. The code is simpler, and we can have tooltip and event on the large mode with progressive rendering now:)Also we brings a new strategy to support special series being separated in an individual
zlevelautomatically. For example, progressively rendered scatter and lines series will be used so that they won't be affected when doing progressive rendering. And for a long time developers need to configure zlevel manually for lines with trail effect, now it can be done automatically.