Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bar-race): label value animation duration after sorting #15916

Merged
merged 5 commits into from Oct 26, 2021
Merged

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Oct 21, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

Details

Before: What was the problem?

Bar-racing interpolated value is not correct. This is because when the sorting order changes, the value animation duration takes the whole animation duration. For example, if the animationDurationUpdate is 5 seconds and the bar order changes at the 4th second. After changing order, the value animation takes another 5 seconds to complete (rather than 1 second).

2021-10-21.10.17.44.mov

After: How is it fixed in this PR?

It doesn't take 5 seconds after sorting.

2021-10-21.10.19.53.mov

Misc

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Oct 21, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

This PR depends on ZRender changes. Please update the ZRender dependency to the latest nightly version including this change, which takes place everyday at 8:00 UTC (16:00 Beijing Time).
You can use npm i zrender@npm:zrender-nightly to update package.json.
If you have any question about this, please leave a comment and we will give you extra help on this.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 25, 2021
@pissang pissang added this to the 5.2.2 milestone Oct 26, 2021
@Ovilia Ovilia merged commit 2c7608b into master Oct 26, 2021
@echarts-bot
Copy link

echarts-bot bot commented Oct 26, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia deleted the fix-bar-race branch October 26, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants