Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set sourceHeader=false not work, will auto find sourceHeader(#16… #16376

merged 1 commit into from
Jan 17, 2022


Copy link

@lefex lefex commented Jan 15, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

if sourceHeader=false

const sourceHeader = retrieve2(newMetaRawOption.sourceHeader, upMetaRawOption.sourceHeader) || null;

the sourceHeader will set null. If sourceHeader is null, echarts will find sourceHeader auto.

if (sourceHeader === 'auto' || sourceHeader == null) {
    arrayRowsTravelFirst(function (val) {
        // '-' is regarded as null/undefined.
        if (val != null && val !== '-') {
            if (isString(val)) {
                startIndex == null && (startIndex = 1);
            else {
                startIndex = 0;
    // 10 is an experience number, avoid long loop.
    }, seriesLayoutBy, dataArrayRows, 10);
else {
    startIndex = isNumber(sourceHeader) ? sourceHeader : sourceHeader ? 1 : 0;

Fixed issues

版本从5.1.2升到5.2.2之后柱状图第一项数据被吞掉 Close #16343
Close #16084


Before: What was the problem?


After: How is it fixed in this PR?



  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs



Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Jan 15, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Copy link

pissang commented Jan 17, 2022

Will it change the behavior when sourceHeader is set to false because it will be changed to 'auto'

@pissang pissang changed the base branch from master to release January 17, 2022 13:07
@pissang pissang added this to the 5.3 milestone Jan 17, 2022
@pissang pissang merged commit 72eb84b into apache:release Jan 17, 2022
Copy link

echarts-bot bot commented Jan 17, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Copy link

Does this PR fix #16084 ?

@apache apache deleted a comment from lefex Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

[Bug] 版本从5.1.2升到5.2.2之后柱状图第一项数据被吞掉
3 participants