fix(tree): fix tree unexpected expand #16548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
linghaoSu
force-pushed
the
fix-tree-unexpected-expand
branch
from
ca5ca81
to
16e5961
Compare
pissang
reviewed
Feb 21, 2022
linghaoSu
force-pushed
the
fix-tree-unexpected-expand
branch
from
1c9e407
to
c42df21
Compare
This was
linked to
issues
Jun 7, 2022
Closed
|
ping @pissang It seems this bug has existed for a long time and many developers have raised similar issues. It would be better if we push forward with this fix. |
pissang
approved these changes
Jun 7, 2022
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
jiawulin001
pushed a commit
to jiawulin001/echarts
that referenced
this pull request
Jun 13, 2022
* fix(tree): fix tree unexpected expand * [fix] remove redunant format code * style: tweak code to be more clear Co-authored-by: pissang <bm2736892@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
fix tree unexpected expand
Fixed issues
Details
Before: What was the problem?
when
edgeShapeis 'curve', the edge is grow from the current node to the parent node. and then whenedgeShapeispolyline, the edge is grow from the current node to the all children node.so, when
edgeShapeis 'curve' and the node is collapsed, all children nodes will be removed, and the edge in these nodes will be removed too.but when the
edgeShapeis 'polyline' and the node is collapsed, all children nodes will be removed, but the edge in the node still exists.After: How is it fixed in this PR?
so we should filter the node that is collapsed when the
edgeShapeispolyline.Misc
Related test cases or examples to use the new APIs
test/tree-polyline.htmlOthers
Merging options
Other information