Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sanky):fallback to black if color were illegal #16614

merged 2 commits into from
Mar 3, 2022


Copy link

@susiwen8 susiwen8 commented Mar 2, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

if zrColor.parse returns undefiend, use #000 as default color

Fixed issues


Before: What was the problem?

Screen Shot 2022-03-02 at 10 31 52 PM

After: How is it fixed in this PR?

Screen Shot 2022-03-02 at 10 31 19 PM


  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs



Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Mar 2, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

src/visual/VisualMapping.ts Outdated Show resolved Hide resolved
@susiwen8 susiwen8 requested a review from pissang March 2, 2022 15:02
@pissang pissang added this to the 5.3.2 milestone Mar 3, 2022
@pissang pissang merged commit e785e61 into apache:master Mar 3, 2022
Copy link

echarts-bot bot commented Mar 3, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@susiwen8 susiwen8 deleted the 16574 branch March 3, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

2 participants