Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolbox): fix toolbox title may be outside of the chart #16704

merged 2 commits into from
Mar 25, 2022


Copy link

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix the toolbox title may be outside of the chart. This PR relies on #16702.

Fixed issues


Before: What was the problem?

Toolbox title may be outside of the chart so that it can't be fully displayed.

1 2
bug1 bug2

After: How is it fixed in this PR?

1 2 3
h-tl h-tl1 h-tr
h-tr1 v-br v-tl


  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

See test/toolbox-title.html


Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Mar 19, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@@ -307,7 +313,7 @@ class ToolboxView extends ComponentView {
emphasisTextConfig.position = 'top';
needPutOnTop = true;
const topOffset = needPutOnTop ? (-5 - rect.height) : (itemSize + 8);
const topOffset = needPutOnTop ? (-5 - rect.height) : (itemSize + 10);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to make the adjusted y aligns with the one not adjusted. The original value 8 seems not perfact.

@pissang pissang added this to the 5.3.2 milestone Mar 20, 2022
@pissang pissang merged commit d3dbf12 into master Mar 25, 2022
Copy link

echarts-bot bot commented Mar 25, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix-toolbox-text-position branch March 25, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants