-
Notifications
You must be signed in to change notification settings - Fork 19.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow areaStyle.origin to take number as input #16719
Conversation
Thanks for your contribution! Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
@jiawulin001 Wow looks great! BTW do you mind adding a test case? |
yes, I can add a test case |
@pissang Any suggestion on which test.ts to add the test case to? I didn't find any existent test file that includes areaStyle, so my plan is to add a new test file under test/ut/spec/series. Is that OK? |
@jiawulin001 We usually add test cases in the test folder. Run |
@pissang Hi, the test case has been added. Check it out! |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Hi @jiawulin001, thanks for your contribution to this new feature and this is just a reminder. Are you working on adding or planning to add this new area origin value for the line series in the documentation? |
@plainheart Oh yes, thank you for your reminding! The PR for updating documentation has been submitted. |
Brief Information
This pull request is in the type of:
What does this PR do?
Allow
series-line.areaStyle.origin
to take number as inputFixed issues
Details
Before: What was the problem?
The choices for series-line.areaStyle.origin for now is limited to 'start', 'end', and 'auto', which correspond to baseline at bottom, top or axis of the view.
After: How is it fixed in this PR?
else if
is added to take number in and set it tovalueStart
. NaN is excluded from such situation and will be treated as undefined.areaStyle.origin
Misc
The API has been changed (apache/echarts-doc#xxx).
This PR depends on ZRender changes (ecomfe/zrender#xxx).
The echarts-doc has not been changed yet, I can submit another PR to update the doc.