Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{yy} should be padded to 2 digits #17064

Merged
merged 1 commit into from May 19, 2022
Merged

{yy} should be padded to 2 digits #17064

merged 1 commit into from May 19, 2022

Conversation

Woonters
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixes padding on {yy} formatting to pad to 2 digits e.g. 1 to 01

Fixed issues

Details

Before: What was the problem?

Echarts.time.format("2001-01-01 00:00:00", "{yy}") --> 1
Should have been 01

After: How is it fixed in this PR?

Added padding to the output

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented May 18, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@Ovilia Ovilia merged commit 6c793aa into apache:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Date Format {yy} doesn't match with documentation
3 participants