fix(custom): fix custom elements probably can't be removed due to NPE when applying leave transition #17308
+57
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! The pull request is marked to be |
Ovilia
approved these changes
Jul 4, 2022
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fix potential null pointer exception when applying leave transition on removed elements.
Fixed issues
Details
Before: What was the problem?
The elements probably can't be removed due to the unexpected NPE when applying leave transition.
After: How does it behave after the fixing?
Detect if the targeted element exists before applying leave transition.
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
Please refer to the first case in
test/custom.htmlOthers
Merging options
Other information
This was brought in the commit 393eb30. (#16225)