Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use offsetWidth/Height to confine tooltip #6277

Merged
merged 1 commit into from Jul 26, 2017
Merged

Conversation

zachjs
Copy link
Contributor

@zachjs zachjs commented Jul 26, 2017

The tooltip confine option currently uses clientWidth and clientHeight to ensure that the tooltip does not go outside the bounds of the chart. However, clientWidth and clientHeight do not include the size of the tooltip's border, which can cause the tooltip to go out of bounds. Using offsetWidth and offsetHeight fixes this issue.

@100pah 100pah merged commit dae94c9 into apache:master Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants