Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip dom append to body, use to top of layer #8049

Merged
merged 3 commits into from Jan 9, 2020

Conversation

xinpureZhu
Copy link
Contributor

@xinpureZhu xinpureZhu commented Mar 28, 2018

#4627 解决 Tooltip 被其它图形遮挡的问题
1522255894822

@pissang
Copy link
Contributor

pissang commented Mar 29, 2018

谢谢!这个 PR 中好像没有处理 tooltip 组件移除或者图表 dispose 后浮层的移除

@xinpureZhu
Copy link
Contributor Author

xinpureZhu commented Mar 29, 2018

疏乎了,已补上提交

@balthazar
Copy link

balthazar commented Mar 28, 2019

你好! Any update on this?

@JoenZhu
Copy link

JoenZhu commented Nov 12, 2019

can anyone merge this pr?

dktjsp
dktjsp previously approved these changes Nov 15, 2019
@pissang pissang added this to the 4.7.0 milestone Nov 18, 2019
@pissang pissang requested a review from 100pah Nov 18, 2019
@100pah
Copy link
Member

100pah commented Jan 9, 2020

This issue will be merged. Thanks to the great contribution of @xinpureZhu .

But a new option tooltip.appendToBody will be added to open this feature.
By default tooltip.appendToBody should be false, otherwise it is probably a big break change for some existing deep-customization usage.
And there would be more factors needed to be considered to ensure the "append to body" works correctly. Subsequent PR is under way.

100pah
100pah approved these changes Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants