FELIX-6812: Fix ConfigInstaller to use listConfigurations instead of getConfiguration #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getConfiguration
Replace getConfiguration() calls with listConfigurations() in
ConfigInstaller.configurationEvent() method to avoid unintentionally
creating new configurations. The getConfiguration() method creates a
configuration if it doesn't exist, which is not the desired behavior
when simply checking for existing configurations.
Changes:
- Use listConfigurations("(service.pid=" + pid + ")") instead of getConfiguration(pid, "?")
- Add proper null and length checks for configuration arrays
- Update corresponding test mocks to reflect the corrected API usage
This prevents unwanted configuration creation during configuration
event handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
getConfiguration()call withlistConfigurations()inConfigInstaller.configurationEvent()method to avoid unintentionally creating new configurations. ThegetConfiguration()method creates a configuration if it doesn't exist, which is not the desired behavior when simply checking for existing configurations.Changes:
listConfigurations("(service.pid=" + pid + ")")instead ofgetConfiguration(pid, "?")This fixes an issue with felix fileinstall reacting upon the CM_UPDATED events and creating a configuration that was already deleted.