Add missing test coverage for Image 404 (FINERACT-1201)

Author: vorburger

fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/StaffImageApiTest.java

@@ -36,13 +36,15 @@ public class StaffImageApiTest {
 
     private RequestSpecification requestSpec;
     private ResponseSpecification responseSpec;
+    private ResponseSpecification responseSpec404;
 
     @BeforeEach
     public void setup() {
         Utils.initializeRESTAssured();
         this.requestSpec = new RequestSpecBuilder().setContentType(ContentType.JSON).build();
         this.requestSpec.header("Authorization", "Basic " + Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey());
         this.responseSpec = new ResponseSpecBuilder().expectStatusCode(200).build();
+        this.responseSpec404 = new ResponseSpecBuilder().expectStatusCode(404).build();
     }
 
     @Test
@@ -57,6 +59,7 @@ public void getStaffImage() {
         Integer staffId = StaffHelper.createStaff(this.requestSpec, this.responseSpec);
         Integer imageId = ImageHelper.createImageForStaff(this.requestSpec, this.responseSpec, staffId);
         assertNotNull(imageId, "Image id should not be null");
+
         String imageAsText = ImageHelper.getStaffImageAsText(this.requestSpec, this.responseSpec, staffId);
         assertNotNull("Image id should not be null", imageAsText);
         assertEquals(ImageHelper.generateImageAsText(), imageAsText);
@@ -67,6 +70,7 @@ public void getStaffImageAsBinary() {
         Integer staffId = StaffHelper.createStaff(this.requestSpec, this.responseSpec);
         Integer imageId = ImageHelper.createImageForStaff(this.requestSpec, this.responseSpec, staffId);
         assertNotNull(imageId, "Image id should not be null");
+
         byte[] imageAsBytes = ImageHelper.getStaffImageAsBinary(this.requestSpec, this.responseSpec, staffId);
         assertNotNull(imageAsBytes, "Image content should not be null");
         assertEquals(251, imageAsBytes.length);
@@ -77,6 +81,7 @@ public void updateImage() {
         Integer staffId = StaffHelper.createStaff(this.requestSpec, this.responseSpec);
         Integer imageId = ImageHelper.createImageForStaff(this.requestSpec, this.responseSpec, staffId);
         assertNotNull(imageId, "Image id should not be null");
+
         imageId = ImageHelper.updateImageForStaff(this.requestSpec, this.responseSpec, staffId);
         assertNotNull(imageId, "Image id should not be null");
     }
@@ -86,7 +91,11 @@ public void deleteStaffImage() {
         Integer staffId = StaffHelper.createStaff(this.requestSpec, this.responseSpec);
         Integer imageId = ImageHelper.createImageForStaff(this.requestSpec, this.responseSpec, staffId);
         assertNotNull(imageId, "Image id should not be null");
+
         imageId = ImageHelper.deleteStaffImage(this.requestSpec, this.responseSpec, staffId);
         assertNotNull(imageId, "Image id should not be null");
+
+        ImageHelper.getStaffImageAsBinary(this.requestSpec, this.responseSpec404, staffId);
+        // No additional Assertion required, the point is the responseSpec404
     }
 }