New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fineract changes for community app bug 1863 #452

Merged
merged 1 commit into from Aug 21, 2018

Conversation

Projects
None yet
3 participants
@tonic889

tonic889 commented Apr 29, 2018

fineract changes for adding guarantor accounts for enhancement openMF/community-app#1863

@tonic889

This comment has been minimized.

Show comment
Hide comment
@tonic889

tonic889 Jul 26, 2018

Corresponding JIRA issue created for the fineact project (https://issues.apache.org/jira/browse/FINERACT-642)

tonic889 commented Jul 26, 2018

Corresponding JIRA issue created for the fineact project (https://issues.apache.org/jira/browse/FINERACT-642)

@tonic889

This comment has been minimized.

Show comment
Hide comment
@tonic889

tonic889 Aug 4, 2018

Hi, I have updated the PR with another commit. Please have another look, thanks.

tonic889 commented Aug 4, 2018

Hi, I have updated the PR with another commit. Please have another look, thanks.

@ShruthiRajaram

This comment has been minimized.

Show comment
Hide comment
@ShruthiRajaram

ShruthiRajaram Aug 6, 2018

Contributor

@tonic889 changes look good. But its advised not to have multiple commits in one PR.
So can you please squash these commits to one and resend the PR.

Contributor

ShruthiRajaram commented Aug 6, 2018

@tonic889 changes look good. But its advised not to have multiple commits in one PR.
So can you please squash these commits to one and resend the PR.

@tonic889

This comment has been minimized.

Show comment
Hide comment
@tonic889

tonic889 Aug 7, 2018

I believe I have squashed the commits properly, please have a look once. Thanks.

tonic889 commented Aug 7, 2018

I believe I have squashed the commits properly, please have a look once. Thanks.

@tonic889

This comment has been minimized.

Show comment
Hide comment
@tonic889

tonic889 Aug 14, 2018

@conradsp Would you be able to merge this PR now that it has been approved? Thanks, Brian

tonic889 commented Aug 14, 2018

@conradsp Would you be able to merge this PR now that it has been approved? Thanks, Brian

@asfgit asfgit merged commit fbf9d1e into apache:develop Aug 21, 2018

@tonic889 tonic889 deleted the tonic889:community-app-1863 branch Aug 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment