FINERACT-806 - Allow customizing Tenants JDBC password, username and driverClassName (not just URL) #698
Conversation
|
In addition to the variable name, this is also missing the equivalent customization for the demo tenant DB, as in https://github.com/apache/fineract/pull/648/files |
|
@xurror .. Are you looking forward to addressing feedback provided by @vorburger ? |
|
Definitely |
|
This should wrap up this issue |
There was a problem hiding this comment.
@xurror sorry when I previously wrote Please use ’fineract_tenants_uid’ (and _pwd) instead of "username" and "password", to make more clear what these system properties are for. I meant fineract_tenants_pwd not _pwd .. would you be willing to change this? Again sorry for the confusion.
|
Oh, sure.
My bad for misinterpreting
…On Sat, Feb 8, 2020, 7:14 PM Michael Vorburger ⛑️ ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@xurror <https://github.com/xurror> sorry when I previously wrote _Please
use ’fineract_tenants_uid’ (and *pwd) instead of "username" and
"password", to make more clear what these system properties are for.* I
meant fineract_tenants_pwd not _pwd .. would you be willing to change
this? Again sorry for the confusion.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#698?email_source=notifications&email_token=AK5B5DFMRCUODDTJLDPU7A3RB3Y67A5CNFSM4KLA7OT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUYW4FY#pullrequestreview-355560983>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK5B5DAA6534DT46L4TO6WLRB3Y67ANCNFSM4KLA7OTQ>
.
|
Added java system properties for username and password to docker-compose Modified sever.xml to get username and password closes https://jira.apache.org/jira/browse/FINERACT-806
|
@xurror sorry I noticed only now that, more importantly than the naming, this doesn't actually work... explaining what needs to be done to fix it takes me the same amount of time as doing it, so let me raise a follow-up PR which takes this commit and adds another one doing the needful - hope OK for you. |
|
No problem, do I need to close this? |
|
closing this in favour of new #713 |
In addition to being able to customize the JDBC URL of the Tenant DB (in the Docker Image, but even otherwise) as introduced in FINERACT-773, it would be good if that JDBC connection's username, password and driverClassName could be overriden via a simple environment variable as well.
This should be relatively straightforward (now) - just apply the "pattern" from https://github.com/apache/fineract/pull/648/files and introduce additional Java System properties (in lower-case) like the fineract_tenants_url from FINERACT-773.